Proxy UDP fallback for hostname ACL routes#3252
Open
TurboTheTurtle wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes UDP fallback routing for hostname-driven ACL modes (notably gfwlist and custom-rules) by ensuring UDP fallback decisions are not accidentally bypassed due to UDP being evaluated against IP endpoints rather than hostnames.
Changes:
- Construct the UDP fallback
ProxyInstancewith routeallwhen the main profile route isgfwlistorcustom-rules. - Preserve existing UDP fallback routing behavior for other route modes by continuing to pass through
profile.route.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| data.proxy = ProxyInstance(profile) | ||
| data.udpFallback = if (fallback == null) null else ProxyInstance(fallback, profile.route) | ||
| data.udpFallback = if (fallback == null) null else ProxyInstance(fallback, when (profile.route) { | ||
| // UDP relay sees IP endpoints, so hostname-only ACL routes would bypass the selected fallback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
allfor gfwlist/custom-rules profiles.Why:
UDP relay decisions are made against IP endpoints. Hostname-heavy ACLs such as gfwlist and custom-rules can therefore bypass the selected UDP fallback even when the user configured one, which prevents QUIC/HTTP3 traffic from reaching the fallback server.
Closes #3070.
Validation:
Please preserve author attribution if this PR is squashed or reworked:
Co-authored-by: Andy Ye 35905412+TurboTheTurtle@users.noreply.github.com